Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: themes not returning correctly #148

Merged
merged 7 commits into from
Feb 7, 2024
Merged

fix: themes not returning correctly #148

merged 7 commits into from
Feb 7, 2024
+5 −4

Conversation

matt-user
Copy link
Contributor

closes FE-87

@matt-user
fix: themes not returning correctly
Loading
Loading status checks…
639d5bf
@matt-user matt-user self-assigned this Jan 30, 2024
@linear Linear
Copy link

linear bot commented Jan 30, 2024

FE-87 Script highlighting on light theme

@matt-user matt-user added the bug Something isn't working label Jan 30, 2024
@matt-user
Copy link
Contributor Author

for some reason updateThemeAppearanceClass does not update useThemeContext so useThemeContext would always return dark.

@matt-user matt-user marked this pull request as ready for review January 30, 2024 16:35
@luizstacio
Merge branch 'main' into matt-user/fix-script-highlighting

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
626c12c
@matt-user
Merge branch 'main' into matt-user/fix-script-highlighting

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
511106b
@matt-user matt-user enabled auto-merge (squash) January 31, 2024 16:46
pedronauck
pedronauck requested changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@pedronauck pedronauck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When reloading using network with no cache and fast 3g it's happening this...

CleanShot 2024-02-01 at 19 44 34@2x

@matt-user
refactor: use radix solution
Loading
Loading status checks…
8e5f7fe
@luizstacio luizstacio requested a review from pedronauck February 6, 2024 03:21
luizstacio
luizstacio requested changes Feb 6, 2024
View reviewed changes
Copy link
Member

@luizstacio luizstacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the new implementation the theme configuration is lost on every refresh.

@matt-user
Copy link
Contributor Author

With the new implementation the theme configuration is lost on every refresh.

@luizstacio if you are referring to the tx screen this happens on main too. I'll investigate the issue and fix it in this pr.

@luizstacio
Copy link
Member

With the new implementation the theme configuration is lost on every refresh.

@luizstacio if you are referring to the tx screen this happens on main too. I'll investigate the issue and fix it in this pr.

@matt-user yeah this is true, I didn't notice that before. Last merge this PR and fix in another task.

@matt-user matt-user merged commit 2bc3ba4 into main Feb 7, 2024
6 checks passed
@matt-user matt-user deleted the matt-user/fix-script-highlighting branch February 7, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedronauck pedronauck

@luizstacio luizstacio

@LuizAsFight LuizAsFight

Assignees

@matt-user matt-user

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matt-user @luizstacio @pedronauck